feat: add post-upload crc32c validation for most uploads#3146
Closed
BenWhitehead wants to merge 3 commits intomainfrom
Closed
feat: add post-upload crc32c validation for most uploads#3146BenWhitehead wants to merge 3 commits intomainfrom
BenWhitehead wants to merge 3 commits intomainfrom
Conversation
product-auto-label
Bot
added
size: l
* Resumable Uploads (JSON & gRPC) * BlobWriteSessionConfigs.getDefault() (JSON & gRPC) * BlobWriteSessionConfigs.bufferToTempDirThenUpload() (JSON & gRPC) * BlobWriteSessionConfigs.bufferToDiskThenUpload() (JSON & gRPC) * BlobWriteSessionConfigs.journaling() (gRPC) BlobWriteSessionConfigs.parallelCompositeUpload() already performs crc32c checksum validation. Storage.create(BlobInfo, byte[]) already performs crc32c checksum validation BlobAppendableUpload already performes crc32c checksum validation BlobWriteSessionConfigs.bidiWrite() will be addressed in the future
BenWhitehead
force-pushed
the
feat/post-upload-crc32c-validation
branch
from
4cca7cb to
286bcd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlobWriteSessionConfigs.parallelCompositeUpload() already performs crc32c checksum validation. Storage.create(BlobInfo, byte[]) already performs crc32c checksum validation
BlobAppendableUpload already performes crc32c checksum validation
BlobWriteSessionConfigs.bidiWrite() will be addressed in the future
Pending